Fix RPC invocation race condition (livekit#565)

* Fix race condition in rpc invocation * nanpa * fix * nanpa * cgo * sm
Evolving-Software · Feb 19, 2025 · b072c16 · b072c16
1 parent bbe0b0c
commit b072c16
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.nanpa/rpc-race.kdl b/.nanpa/rpc-race.kdl
@@ -0,0 +1 @@
+patch package="livekit-ffi" type="fixed" "Fix RPC invocation race bug"
diff --git a/livekit-ffi/src/server/participant.rs b/livekit-ffi/src/server/participant.rs
@@ -140,6 +140,8 @@ async fn forward_rpc_method_invocation(
     let (tx, rx) = oneshot::channel();
     let invocation_id = server.next_id();
 
+    room.store_rpc_method_invocation_waiter(invocation_id, tx);
+
     let _ = server.send_event(proto::ffi_event::Message::RpcMethodInvocation(
         proto::RpcMethodInvocationEvent {
             local_participant_handle: local_participant_handle as u64,
@@ -152,8 +154,6 @@ async fn forward_rpc_method_invocation(
         },
     ));
 
-    room.store_rpc_method_invocation_waiter(invocation_id, tx);
-
     rx.await.unwrap_or_else(|_| {
         Err(RpcError {
             code: RpcErrorCode::ApplicationError as u32,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		patch package="livekit-ffi" type="fixed" "Fix RPC invocation race bug"