Fix RPC invocation race condition #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
theomonnom
approved these changes
Feb 4, 2025
This was referenced Feb 4, 2025
rileyseaburg
pushed a commit
to Evolving-Software/livekit-rust-sdks
that referenced
this pull request
Feb 19, 2025
* Fix race condition in rpc invocation * nanpa * fix * nanpa * cgo * sm
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if your handler returned very quickly it was possible to send the invocation response back over FFI before the waiter was stored, resulting in
error sending rpc method invocation response: No caller foundon the handler side and aResponse timeouton the caller side.easy fix, and verified by running a test script in python with 100 calls to immediate-return handlers. in main i saw a failure rate of 11% and no errors at all with this branch. it didn't seem to matter whether the handlers were marked sync or not on the python side.