Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feature] Support docker compose as plugin #137

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

tokland
Copy link
Contributor

@tokland tokland commented Feb 19, 2025

Detected on: https://app.clickup.com/t/2he0te1, https://app.clickup.com/t/1mufv53

This one was tricky. Latest Docker package upgrades are making it increasingly difficult to make docker-compose work. See, for example:

We can no longer delay the upgrade from docker-compose to docker compose (as a plugin), which is the modern recommended approach. Ubuntu systems support this through the docker-compose-v2 package.

  • Change code to use "docker compose" instead of docker-compose
  • Update README

Note that the docker compose plugin is a drop-in replacement a docker-compose, but it has been completely rewritten (python -> go). so this is not a breaking change, but definitely we should keep an eye to see all the configurations used in EST keep working. I've tested with SP and my local dockers, and for now, everything works as before.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant