Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feature] Support docker compose as plugin #137

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
On Ubuntu 22.04:

```
$ sudo apt install docker.io docker-compose python3 python3-setuptools
$ sudo apt install docker.io docker-compose-v2 python3 python3-setuptools
```

On Windows 10:
Expand Down
7 changes: 3 additions & 4 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
Flask==2.0.3
Flask==3.1.0
python-dotenv
Flask_Cors==3.0.10
Werkzeug==2.3.7
requests==2.31.0
Flask_Cors
requests==2.32.3
PyYAML
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

setuptools.setup(
name="d2_docker",
version="1.14.0",
version="1.15.0.b2",
description="Dockers for DHIS2 instances",
long_description=open("README.md", encoding="utf-8").read(),
keywords=["python"],
Expand Down
4 changes: 2 additions & 2 deletions src/d2_docker/commands/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def setup(_parser):

def run(_args):
utils.run(["docker", "-v"])
utils.run(["docker-compose", "-v"])
utils.run(["docker", "compose", "version"])
d2_docker = get_d2_docker_version()
if d2_docker:
print("d2-docker version {}".format(d2_docker))
Expand All @@ -32,7 +32,7 @@ def get_field(command, field_index):

def get_versions():
docker = get_field(["docker", "-v"], 2)
docker_compose = get_field(["docker-compose", "-v"], 3)
docker_compose = get_field(["docker", "compose", "version"], 3)
d2_docker = get_d2_docker_version()
return dict({"docker": docker, "docker-compose": docker_compose, "d2-docker": d2_docker})

Expand Down
1 change: 0 additions & 1 deletion src/d2_docker/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: "3"
services:
core:
image: "${DHIS2_CORE_IMAGE}"
Expand Down
4 changes: 2 additions & 2 deletions src/d2_docker/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def process_yaml(data):

temp_compose = build_docker_compose(process_yaml)

return run(["docker-compose", "-f", temp_compose.name, "-p", project_name, *args], env=env, **kwargs)
return run(["docker", "compose", "-f", temp_compose.name, "-p", project_name, *args], env=env, **kwargs)


def build_docker_compose(process_yaml):
Expand Down Expand Up @@ -537,7 +537,7 @@ def add_core_image_arg(parser):

@contextlib.contextmanager
def running_containers(image_name, *up_args, **run_docker_compose_kwargs):
"""Start docker-compose services for an image in a context manager and stop it afterwards."""
"""Start docker compose services for an image in a context manager and stop it afterwards."""
try:
run_docker_compose(["up", "-d", *up_args], image_name, **run_docker_compose_kwargs)
status = get_image_status(image_name)
Expand Down