Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FLX-461 Fix - Apps which are not properly installed can't be uninstalled #728

Merged
merged 1 commit into from
Feb 1, 2024
Merged

FLX-461 Fix - Apps which are not properly installed can't be uninstalled #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions daemon/modules/apps/src/apps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,8 @@ auto apps_t::http_sideload(std::string manifest_string) //
auto apps_t::http_uninstall(apps::key_t app_key) //
-> crow::response
{
if (!is_installed(app_key)) {
auto response = json_t{};
response["additionalInfo"] = "Cannot uninstall " + to_string(app_key) + ", which is not installed";
return {crow::status::BAD_REQUEST, "json", response.dump()};
if (!query(app_key)) {
return crow::response(crow::status::NOT_FOUND);
}

auto job_id = _impl->queue_uninstall(std::move(app_key));
Expand Down
Loading