-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[SM64] Settings Rework #280
Conversation
fast64-animations_updater/fast64-animations_updater_status.json
Outdated
Show resolved
Hide resolved
necessary for future properties groups to be included into the sm64 scene class (like animation export in my future animation rework pr)
merge conflicts are most likely from black formatting commit 7031047 to merge main I suggest
|
All done :) |
Oh and I guess I will wait for sauren's pr to be approved I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another round
Can you document the "(sm64) repo settings" feature in the sm64 readme, say it exists, the default name, what's in it, when is it written/read...
will do this soon! |
bring from dict and to dict to the rdp property class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it worked pretty well, but I didn't do an extensive test and combover of all the code because there was a lot of changes. I imagine the rest of the code will be good but I need to look at it closer.
@jesusyoshi54 btw its fixed i forgot one line |
high sensitivity settings in my mouse are gonna be the end of me some day, please ignore that |
Going back to draft until I get the new json methods in my glTF branch finished so I can use those for world defaults instead, will try do it tomorrow |
Ported over to json logic for rdp settings from #368 |
I hate to make changes after something is already approved, but this is a bug fix and an update to keep up with glTF2 branch, doesn´t change functionality and is tested, sorry |
We mergin' ? |
I tested it again and it works so sure |
Some reorganizing, putting stuff into sm64 specific property groups, new repo settings system, some cleaner ui with more warnings, create simple level button, new warnings for import and export ROMs just because i was adding them to the ui anyways.
Tried to keep this within scope as much as possible.
Please feel free to comment on anything and everything.