Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add the test of cube export and import #317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coco875
Copy link
Contributor

@coco875 coco875 commented Mar 1, 2024

No description provided.

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Aug 19, 2024

Sorry for never getting around to reviewing this, but before commenting on the code what porpuse does this serve?
Yes automated testing is always nice, but this tests so very little, basically just makes sure an exception isn´t happening in two methods (and you're not even calling the operators themselves).

@Yanis002
Copy link
Contributor

for oot we probably want to import a scene, export one and make sure the DL/Collision/Skeleton/Animation exporters/importers all work

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Aug 19, 2024

for oot we probably want to import a scene, export one and make sure the DL/Collision/Skeleton/Animation exporters/importers all work

One of my big issues with this is what would count as works?

@coco875
Copy link
Contributor Author

coco875 commented Aug 20, 2024

Other solutions will be to use a real rom but can make some legal issues

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants