Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: adds Bluesky buttons to o-share #1911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: adds Bluesky buttons to o-share #1911

wants to merge 1 commit into from

Conversation

aendra-rininsland
Copy link
Member

@aendra-rininsland aendra-rininsland commented Dec 23, 2024 •
edited
Loading

Describe your changes

N.b., I'm not sure this is ready yet, please let me know if there's more I need to do. Thanks!

This adds Bluesky sharing intent buttons. N.b., this only uses the web endpoint; there's a bluesky:// protocol endpoint that is probably preferable on mobile but I'm not sure how to reference it in an isomorphic context.

See: https://docs.bsky.app/docs/advanced-guides/intent-links#compose-post

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@notlee notlee temporarily deployed to origami-webs-o-share-bl-rgvcht December 23, 2024 15:52 Inactive
@notlee notlee temporarily deployed to origami-webs-o-share-bl-rgvcht December 23, 2024 16:00 Inactive
@notlee notlee temporarily deployed to origami-webs-o-share-bl-rgvcht December 23, 2024 16:05 Inactive
@aendra-rininsland
Copy link
Member Author

N.b., I've noticed that handles don't link very well at this point; I've opened an issue here:

bluesky-social/social-app#7258

@j-mes
Copy link
Member

j-mes commented Jan 30, 2025

N.b., I've noticed that handles don't link very well at this point; I've opened an issue here:

bluesky-social/social-app#7258

Hi @aendra-rininsland is there any update with this one? As looking on your issue with Bluesky, it seems they haven't responded to you yet.

@aendra-rininsland
Copy link
Member Author

@j-mes Hi! Sorry for the delay in merging this, I'm currently in a discussion with a few folks about how best to manage the share button request, though there's a bit of a consensus that a better outcome than adding another button is to redesign the sharing palette. Will update once we arrive at a next action.

@j-mes
Copy link
Member

j-mes commented Jan 31, 2025

@j-mes Hi! Sorry for the delay in merging this, I'm currently in a discussion with a few folks about how best to manage the share button request, though there's a bit of a consensus that a better outcome than adding another button is to redesign the sharing palette. Will update once we arrive at a next action.

No apologies needed 😄 I'm only being nosy and wondering if you had reached a suitable conclusion for everyone involved!

@j-mes
Copy link
Member

j-mes commented Feb 11, 2025

FWIW: Blue Sky icon is in o3-icons: #1962

This PR is still valid I believe, if you want this in o2-icons. Am I correct in thinking this? @frshwtr @notlee?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@frshwtr frshwtr frshwtr approved these changes

@ft-dependency-auto-merger ft-dependency-auto-merger Awaiting requested review from ft-dependency-auto-merger ft-dependency-auto-merger is a code owner

Assignees
No one assigned
Labels
o-share
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aendra-rininsland @j-mes @frshwtr @notlee