ci: Update binaries release when they change #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
piotradamczyk5
added a commit
to Flank/flank
that referenced
this pull request
Dec 14, 2020
Fixes #896 This PR delete submodule for [binaries ](https://github.com/Flank/binaries) and download them at runtime from [release page ](https://github.com/Flank/binaries/releases) based on os system ## Test Plan > How do we know the code works? `macOs` -> all should work by default because previously binaries were not copied on macOS `linux` -> it download binaries from [release page](https://github.com/Flank/binaries/releases) at runtime to `<user_home>/.flank` directory and unpack them `windows` -> it works similar to `linux` version, however, full support will be available after #1134 All tests should work properly ## Checklist - [x] Documented - [x] Unit tested - [x] Downloading binaries for Linux and Windows at runtime - [x] Create binaries release for Linux and Windows - [x] Update binaries assets after each change on binaries repo [release page](https://github.com/Flank/binaries/releases) >> [PR](Flank/binaries#4) - [x] Delete submodule - [x] Update Github Actions to do not checkout submodules
pawelpasterz
approved these changes
Dec 15, 2020
jan-goral
approved these changes
Dec 15, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time when files changed, we need to update the release files per platform