-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci: Get rid of binaries submodule #1385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
============================================
- Coverage 77.58% 77.26% -0.33%
Complexity 717 717
============================================
Files 248 250 +2
Lines 4788 4825 +37
Branches 915 922 +7
============================================
+ Hits 3715 3728 +13
- Misses 572 596 +24
Partials 501 501 |
e659ccd
to
bb706b5
Compare
c0de1a3
to
bb706b5
Compare
Timestamp: 2020-12-14 14:23:39 |
18d7b0b
to
17ed36e
Compare
6e76562
to
93f9cbd
Compare
1. checkout binaries [repository](https://github.com/Flank/binaries) | ||
1. update them using: | ||
- `updateBinariesWithFlankBash` will update binaries for Linux and Windows using `flank-scripts` | ||
- `update.sh` (old method). It will update binaries for Linux OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the old method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is standalone without flank-scripts needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks well, but I would love to have this implementation in the java-library module linked to the test_runner
as Gradle dependency, maybe not now, it could be in another PR.
Some of the code looks a little bit redundant according to flank-scripts, for example, utilities for unzipping & symlinks, probably also could be moved to another library module shared between download-binaries
(?) and flank-scripts
.
Yeah I think that we could do some shared module which has common logic for other modules, I will create a ticket for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tested on windows, works!
Fixes #896
This PR delete submodule for binaries and download them at runtime from release page based on os system
Test Plan
macOs
-> all should work by default because previously binaries were not copied on macOSlinux
-> it download binaries from release page at runtime to<user_home>/.flank
directory and unpack themwindows
-> it works similar tolinux
version, however, full support will be available after #1134All tests should work properly
Checklist