Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update device list and remove iphone8 references #2357

Closed
wants to merge 15 commits into from
Closed

Update device list and remove iphone8 references #2357

wants to merge 15 commits into from

Conversation

kozaxinan
Copy link
Contributor

Fixes #

iphone8 device is not available on FTL anymore. Integration tests are failing because of usage of iphone8 device. Current default is iphone13pro, and this pr replaces iphone8 usages with iphone13pro.

Test Plan

How do we know the code works?

Integration tests should finish successfully.
.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@adamvduke
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/4609513692

@kozaxinan
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

Integration tests failed ❌
Windows status success - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/4621858607

@Fry-kun
Copy link
Collaborator

Fry-kun commented Apr 13, 2023

I tried running integration tests locally, it's failing because the app is targeted for older ios version. Pretty sure it needs to be re-targeted & rebuilt, but the scripts for that aren't working so far.

kozaxinan and others added 6 commits April 28, 2023 10:59
@kozaxinan
Shard calculation should not use skipped tests time
c68958b
@Fry-kun @kozaxinan
Removed test case time overhead calculation, as it was incorrectly pr…
0388c66 
…ocessing deflake reruns & reporting negative test case times. (#2364)

Overhead (as described in #557) no longer exists in FTL, so this feature is not useful anymore.

Fixes #2363
@Fry-kun @kozaxinan
Bringing integration tests back to life
70b4a7e 
* Updated default iOS test device from iphone8/12 to iphone13pro/15.7 (#2366)
  FTL recently deprecated iphone8/12, so integration tests have been
  failing
* Updated local copy of FTL catalog to recent version
* Replaced iOS integration test app EarlGreyExample with FlankExampleTest
  EarlGreyExample is failing on newer OS/xcode. Current copy is based on
  EarlGreyExample v1, which is no longer maintained. V2 is pretty hard
  to get up and running, so switching to FlankExampleTest is the easiest
  way to unblock integration tests.
@google-flank-bot @Fry-kun @kozaxinan
[Automatic PR] Generate release notes (#2367)
dc22bbe 
Co-authored-by: Fry-kun <Fry-kun@users.noreply.github.com>
@kozaxinan
merge master
4b14736
@kozaxinan
Revert "Shard calculation should not use skipped tests time"
159fc9f 
This reverts commit c68958b.
@Fry-kun
Copy link
Collaborator

Fry-kun commented Apr 28, 2023

Replaced the default device in #2366.
Is this PR still needed?

@kozaxinan
Copy link
Contributor Author

Thank you for updating the ios catalogue. I rebased my branch on master. This Pr now has an updated android catalogue. It is not necessary but nice to have at the moment. I am okay to close this one because I originally intended to fix the integration tests. But now this PR is more or updating the android catalogue. Feel free to close or merge.

Fry-kun
Fry-kun reviewed Apr 28, 2023
View reviewed changes
docs/flank-output-investigation/flank_current_output.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is labeled "investigation", I'd err on the side of leaving these files as-is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted those changes. Thank you for the context of investigation.

@adamvduke
Copy link
Contributor

superseded by #2402

@adamvduke adamvduke closed this Jul 10, 2023
@kozaxinan kozaxinan deleted the iphone8_fix branch July 10, 2023 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Fry-kun Fry-kun Fry-kun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozaxinan @adamvduke @Fry-kun