Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Removed test case time overhead calculation #2364

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Fry-kun
Copy link
Collaborator

@Fry-kun Fry-kun commented Apr 13, 2023

test case time overhead calculation was incorrectly processing deflake reruns & reporting negative test case times.

Overhead (as described in #557) no longer exists in FTL, so this feature is not useful anymore.

Fixes #2363

Test Plan

How do we know the code works?
Unit tests updated

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

…ocessing deflake reruns & reporting negative test case times.

Overhead (as described in #557) no longer exists in FTL, so this feature is not useful anymore.

Fixes #2363
@Fry-kun Fry-kun marked this pull request as ready for review April 13, 2023 17:51
@adamvduke adamvduke changed the title Removed test case time overhead calculation, as it was incorrectly pr… fix: Removed test case time overhead calculation Apr 13, 2023
@github-actions
Copy link
Contributor

Timestamp: 2023-04-13 17:58:53
Buildscan url for ubuntu-workflow run 4692288487

@Fry-kun Fry-kun merged commit f31dd9d into master Apr 13, 2023
@Fry-kun Fry-kun deleted the negative_test_timing_#2363 branch April 13, 2023 18:24
runningcode pushed a commit to runningcode/fladle that referenced this pull request Aug 16, 2023
* update to latest Flank version for correct test time calculations Flank/flank#2364

* mend
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test case times sometimes reported as negative
2 participants