Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to latest Flank #334

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

justintuchek
Copy link
Contributor

Update to latest Flank version for correct test time calculations Flank/flank#2364

Ran test locally, we are already running with this through flankVersion and seems to be working well

@runningcode
Copy link
Owner

There's a few other place to update here as well can you do a find and replace on that version number in the project?

@justintuchek
Copy link
Contributor Author

Yup!

I think I got everything

There's a few other trailing versions specified for integration + validation test. If you'd like those too I can push up another commit

Tested locally and seem to be passing, fit within the assertions for everything except the test covering non-existent Flank versions (as expected)

@runningcode runningcode merged commit f5d45ac into runningcode:master Aug 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants