Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merging PythonAddDeclarationPass into SymbolResolver using HasDynamicDeclarations trait #2006

Closed
wants to merge 2 commits into from
Closed

Merging PythonAddDeclarationPass into SymbolResolver using HasDynamicDeclarations trait #2006

wants to merge 2 commits into from

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Jan 29, 2025 •
edited
Loading

Work in progress. Also tries to merge the python declaration pass into the symbol resolver.

Certain PRs are needed before we can merge this:

@oxisto oxisto changed the title Providing a new HasDynamicVariable language trait Merging PythonAddDeclarationPass into SymbolResovler using HasDynamicDeclarations trait Jan 29, 2025
@oxisto oxisto linked an issue Jan 29, 2025 that may be closed by this pull request
Confusion in python symbol resolving when accessing fields in static class context #2004
Open
@oxisto oxisto added the python label Jan 29, 2025
This was referenced Jan 30, 2025
Merged
Closed
@oxisto oxisto force-pushed the dynamic-declarations branch 2 times, most recently from 9f002df to f6ccafd Compare January 31, 2025 19:09
@oxisto oxisto changed the base branch from main to revamped-imported-symbols February 6, 2025 20:24
@oxisto oxisto force-pushed the dynamic-declarations branch from 13d87f8 to 8820889 Compare February 6, 2025 20:31
@oxisto oxisto force-pushed the revamped-imported-symbols branch 3 times, most recently from 03a114d to 1de14ed Compare February 10, 2025 15:24
Base automatically changed from revamped-imported-symbols to main February 10, 2025 15:28
@oxisto oxisto force-pushed the dynamic-declarations branch 3 times, most recently from a7e3a5d to 6c0ce11 Compare February 11, 2025 10:22
@oxisto oxisto changed the title Merging PythonAddDeclarationPass into SymbolResovler using HasDynamicDeclarations trait Merging PythonAddDeclarationPass into SymbolResolver using HasDynamicDeclarations trait Feb 11, 2025
oxisto and others added 2 commits February 11, 2025 15:50
@oxisto
Added functions to insert a node in an existing EOG path
b45fb46 
This adds two new extension functions `insertNodeBeforeInEOGPath` and `insertNodeAfterwardInEOGPath` that insert a new node into an existing EOG path either before or after the node of reference.
@oxisto
Providing a new HasDynamicVariable language trait
096c652 
Merging the old python extra pass into the `SymbolResolver` using the trait.
@oxisto oxisto force-pushed the dynamic-declarations branch from 0779172 to 096c652 Compare February 11, 2025 14:55
@oxisto
Copy link
Member Author

oxisto commented Feb 25, 2025

We will implement another approach using the EOG fix point iteration. Closing this for now.

@oxisto oxisto closed this Feb 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maximiliankaul maximiliankaul Awaiting requested review from maximiliankaul maximiliankaul will be requested when the pull request is marked ready for review maximiliankaul is a code owner

@lshala lshala Awaiting requested review from lshala lshala will be requested when the pull request is marked ready for review lshala is a code owner

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss will be requested when the pull request is marked ready for review konradweiss is a code owner

@KuechA KuechA Awaiting requested review from KuechA KuechA will be requested when the pull request is marked ready for review KuechA is a code owner

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion in python symbol resolving when accessing fields in static class context
1 participant
@oxisto