Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prefer static call to validate callback and use more precise exception #458

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Prefer static call to validate callback and use more precise exception #458

merged 1 commit into from
Jul 4, 2023

Conversation

VincentLanglet
Copy link
Contributor

Hi @tobias-93,

I just noticed that

  • JsonpCallbackValidator::validate is static so doesn't require to instanciate a class
  • BadRequestHttpException should be preferred over HttpException for a 400 status

So I made the PR :)

@tobias-93 tobias-93 merged commit 9493cbd into FriendsOfSymfony:master Jul 4, 2023
@tobias-93
Copy link
Collaborator

Thanks @VincentLanglet

@tobias-93 tobias-93 mentioned this pull request Jul 4, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @tobias-93 @dmaicher