Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prefer static call to validate callback and use more precise exception #458

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Prefer static call to validate callback and use more precise exception #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Controller/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Session\Flash\AutoExpireFlashBag;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

/**
* Controller class.
Expand Down Expand Up @@ -82,9 +82,8 @@ public function indexAction(Request $request, $_format): Response
$content = $this->serializer->serialize($routesResponse, 'json');

if (null !== $callback = $request->query->get('callback')) {
$validator = new \JsonpCallbackValidator();
if (!$validator->validate($callback)) {
throw new HttpException(400, 'Invalid JSONP callback value');
if (!\JsonpCallbackValidator::validate($callback)) {
throw new BadRequestHttpException('Invalid JSONP callback value');
}

$content = '/**/'.$callback.'('.$content.');';
Expand Down