Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

forc-deploy asks password for non-existing wallet #6703

Open
kayagokalp opened this issue Nov 8, 2024 · 0 comments · May be fixed by #6704
Open

forc-deploy asks password for non-existing wallet #6703

kayagokalp opened this issue Nov 8, 2024 · 0 comments · May be fixed by #6704
Assignees
Labels
bug Something isn't working forc-deploy Everything to do with forc-deploy

Comments

@kayagokalp
Copy link
Member

Problem

Currently if the user does not have a wallet, forc-deploy offers them to create a new one. We will also offer them to import if they have one already created with #6680. But even there is no wallet at the default path the ask for password is invoked before checking this situation so we end up asking for a password for a wallet that does not exists.

...
  Confirming transactions [deploy final-contract]
             Network: https://testnet.fuel.network
             Wallet: /Users/kayagokalp/.fuel/wallets/.wallet
✔ Wallet password · ****
? Could not find a wallet at "/Users/kayagokalp/.fuel/wallets/.wallet", would you like to create a new one? [y/N]:  (y/n) ›

Fix

This is a basic logic error and the order of invoking password prompt and checking/creating a new wallet should be switched.

@kayagokalp kayagokalp added bug Something isn't working forc-deploy Everything to do with forc-deploy labels Nov 8, 2024
@kayagokalp kayagokalp self-assigned this Nov 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working forc-deploy Everything to do with forc-deploy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant