fix: forc-deploy asks for password before checking if the wallet exists #6704
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
commented
Nov 8, 2024
|
Ah, there's a failing test. |
kayagokalp
force-pushed
the
kayagokalp/6703
branch
from
8c31378
to
29e4562
Compare
|
Updated and it should be good now :) The failing test assumed it was testing wrong password but it was not. Due to the same bug that is being solved with this PR, cli was asking a password for a wallet that does not exists. Updated the test, as the relevant section in the code also states we need to be able to override the default path for tests to test the happy path as well. I'll try to look into it next week 👌 |
|
Thinking about this I am curious what happens if you run cargo -t locally after this change if you a have a wallet locally will the test fail 🤔 We should probably think about overriding the default path for tests so that the tests ensure reproducability |
zees-dev
approved these changes
Nov 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6703 and unblocks #6680.
Forc-deploy was asking for a password without checking if a wallet exists or not and the check for existence was happening after the password prompt. This meant we were asking for a password even when the wallet does not exists.
Below examples are taken in a system where the wallet does not exists at the default path (a fresh system):
Before
... Confirming transactions [deploy final-contract] Network: https://testnet.fuel.network Wallet: /Users/kayagokalp/.fuel/wallets/.wallet ✔ Wallet password · **** ? Could not find a wallet at "/Users/kayagokalp/.fuel/wallets/.wallet", would you like to create a new one? [y/N]: (y/n) ›After
... Confirming transactions [deploy final-contract] Network: https://testnet.fuel.network ? Could not find a wallet at "/Users/kayagokalp/.fuel/wallets/.wallet", would you like to create a new one? [y/N]: (y/n) ›