-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Forc-deploy import wallet support if non-existent wallet #6680
Conversation
14f4391
to
a5fb938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current behaviour performs the password check which is much more upstream in the code; changing that would imply a re-factor which may have knock-on effects. |
I think we should discuss the necessary refactor to do this, because it feels a little confusing as it is. If i don't have a wallet it is highly likely that I don't have necessary context to understand what password I need to enter once that is prompted. So it might be worth doing the refactor before merging this. If you can come up with some kind of a description of what you need to be changed exactly I am more than happy to help out! I want to clean forc deploy paths for some time now even have a tracking issue for it. #6259 |
I believe this should be done in another PR as the scope could become much larger. |
I don't think we should merge this as it is because as it is this will be confusing, my suggestion would be to keep this ready to go and first fix the upstream and after that using the already fixed upstream let's merge this PR. I am curious about what needs to be changed to fix this issue and if i understood correctly those needs to be fixed in forc-wallet, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out this situation is present for creating a new wallet as well. I opened #6704, once merged it will also fix the problem we are having here. If we can merge that and rebase this one wallet password won't be prompted.
1a45b61
to
fc07201
Compare
Description
forc-deploy