Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dockerfile for apollo collaboration server fails to build on Mac #455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shashankbrgowda
Copy link
Contributor

The current Dockerfile for the collaboration server ghcr.io/gmod/apollo-collaboration-server:devel is not building successfully and does not run on a Mac machine. I updated the Dockerfile to use node:18-alpine as the base image and made some modifications to the build stages. These changes allow the image to build correctly and run on Mac environments without issues.

Copy link
Contributor

@garrettjstevens garrettjstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few changes here, are all of them necessary or is it possible to do a more minimal set of changes? At minimum, the LABEL needs to be replaced since that's used by the GitHub container registry.

In particular, I'd like to keep all three build stages since it offers better caching, which helps when having to build multiple times. Another thing is that we should avoid copying the whole .yarn directory over from the build step, since it includes all the installed dev dependencies, which will increase the size of our published image (yarn workspaces focus installs only the dependencies and not the dev dependencies)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants