SRCH-5171 & SRCH-5140: Upgrade to Rails 7.1.0 - Remove ruby 3.0.6 from test matrix #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorawoodford
suggested changes
May 13, 2024
There was a problem hiding this comment.
@luisgmetzger Once change request inline.
Also, I'm not sure why your tests are hanging because I your fork's runs, but we'll need to figure that out to get this merge eligible. Happy to help - hopefully it's just as simple as re-running them.
lorawoodford
suggested changes
May 29, 2024
| photos.to_a.last.dateupload.to_i | ||
| rescue StandardError => e | ||
| Rails.logger.warn("Trouble getting oldest upload date from photo #{photos.to_a.last}: #{e}") | ||
| photo_array = photos.respond_to?(:photos) ? photos.photos.to_a : photos.to_a |
There was a problem hiding this comment.
Why are these changes necessary? The change to the warning also seems more confusing/less helpful/less specific than the current version, while also seeming like a change in functionality? Ditto the changes starting on ln 56.
There was a problem hiding this comment.
@lorawoodford - As for these updates ... I could seem to escape the changes here (especially the mocks) after the upgrade and rspec-rails version upgrade.
luisgmetzger
changed the title
luisgmetzger
requested review from
lorawoodford
and removed request for
stevenbarragan
stevenbarragan
added a commit
that referenced
this pull request
Oct 21, 2024
* SRCH-5217 Set production log level through the env (#256) * SRCH-5217 SRCH-5168 Fix error `visit_Psych_Nodes_Alias' ... (Psych::BadAlias)`. Fix suid & sgid deletion, remove crontabs and init files (#257) * Set RAILS_LOG_TO_STDOUT=1 BUNDLE_WITHOUT=development (#258) * SRCH-5020 (#259) * SRCH-5171 & SRCH-5140: Upgrade to Rails 7.1.0 - Remove ruby 3.0.6 from test matrix (#252) * SRCH-5171: Upgrade to Rails 7.1.0 * Remove ruby 3.0.6 from test matrix
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review. If you cannot complete an item below, replace the checkbox with the⚠️
:warning:emoji and explain why the step was not completed.Functionality Checks
You have merged the latest changes from the target branch (usually
main) into your branch.Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.
PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.
Automated checks pass. If Code Climate checks do not pass, explain reason for failures:
Process Checks