Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SRCH-5020 #259

Merged
merged 4 commits into from
May 29, 2024
Merged

SRCH-5020 #259

merged 4 commits into from
May 29, 2024

Conversation

sb-ebukaanene
Copy link
Contributor

Summary

  • CICD pipeline

Checklist

Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review. If you cannot complete an item below, replace the checkbox with the ⚠️ :warning: emoji and explain why the step was not completed.

Functionality Checks

  • [x ] You have merged the latest changes from the target branch (usually main) into your branch.

  • Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.

  • PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.

  • Automated checks pass. If Code Climate checks do not pass, explain reason for failures:

Process Checks

  • You have specified at least one "Reviewer".

Copy link
Contributor

@stevenbarragan stevenbarragan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of extra comments.

Something else I'd like to go through tomorrow is how this is secure.

Copy link
Contributor

@stevenbarragan stevenbarragan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@sb-ebukaanene sb-ebukaanene merged commit 95e18b7 into GSA:main May 29, 2024
3 checks passed
stevenbarragan added a commit that referenced this pull request Oct 21, 2024
* SRCH-5217 Set production log level through the env (#256)
* SRCH-5217 SRCH-5168 Fix  error `visit_Psych_Nodes_Alias' ... (Psych::BadAlias)`.  Fix suid & sgid deletion, remove crontabs and init files (#257)
* Set RAILS_LOG_TO_STDOUT=1 BUNDLE_WITHOUT=development (#258)
* SRCH-5020 (#259)
* SRCH-5171 & SRCH-5140: Upgrade to Rails 7.1.0 - Remove ruby 3.0.6 from test matrix (#252)
* SRCH-5171: Upgrade to Rails 7.1.0 
* Remove ruby 3.0.6 from test matrix
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants