This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Remove initialAspectRatio #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Preview (static) for commit 7847b59 available at https://pr-6269-static-dot-dcc-staging.uc.r.appspot.com/. The following pages likely changed with this PR: |
rachelandrew
approved these changes
May 11, 2023
rachelandrew
approved these changes
May 11, 2023
Co-authored-by: Rachel Andrew <rachelandrew@google.com>
|
@AaronForinton Please revert. I'll merge when Chrome implementation is in pair with Chrome spec. |
rachelandrew
added a commit
that referenced
this pull request
May 11, 2023
This reverts commit 2492d35.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't currently support locking the aspect ratio, having
initialAspectRatioas an option doesn't really make sense, so we should remove it.Spec PR: WICG/document-picture-in-picture#36
Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/4518212
FYI @steimelchrome @liberato-at-chromium