Remove initialAspectRatio #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2023
avelad
pushed a commit
to shaka-project/shaka-player
that referenced
this pull request
May 11, 2023
…AspectRatio (#5224) The `initialAspectRatio` option was removed from the Document Picture-in-Picture spec in favour of `width` and `height`, so we should use them. See WICG/document-picture-in-picture#36
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 11, 2023
Since we don't currently support locking the aspect ratio, having initialAspectRatio as an option doesn't really make sense, so we should remove it. Spec PR: WICG/document-picture-in-picture#36 Bug: 1444658 Change-Id: I838dac9d4b3952dc1893308b2637b0de915a4acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4518212 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1142780}
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't currently support locking the aspect ratio, having initialAspectRatio as an option doesn't really make sense, so this PR removes it