[1/4] Add support for WebDX Groups, Feature-Group Mappings & Group Descendants #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
changed the title
jcscottiii
force-pushed
the
jcscottiii/refactor-spanner-client
branch
from
29704a5
to
f5430a9
Compare
jcscottiii
force-pushed
the
jcscottiii/add-groups-table
branch
from
0a28386
to
970e7a4
Compare
jcscottiii
changed the title
dlaliberte
approved these changes
Aug 16, 2024
jrobbins
approved these changes
Aug 16, 2024
**Description:** This PR introduces the foundational schema and data access layer for managing WebDX Groups and their associations with Web Features in Spanner. **Key Changes** * **Schema:** * Created the `WebDXGroups` table to store group metadata. * Created the `WebFeatureGroups` table to map web features to their associated groups. * Created the `WebDXGroupDescendants` to include the descendant group IDs for efficient querying * **Data Access Layer:** * Implemented `UpsertGroup` and `GetGroupIDFromGroupKey` methods in the `Client` struct to interact with the `WebDXGroups` table. * Implemented `UpsertWebFeatureGroup` to manage feature-group mappings in the `WebFeatureGroups` table. * Implemeneted `UpsertGroupDescendantInfo` to manage mappings of groups to all descendant groups. * Introduced helper structs and mappers (`WebFeatureGroup`, `groupSpannerMapper`, etc.) to facilitate data mapping and persistence. **Purpose** * Enables storing and retrieving information about WebDX Groups and their relationships with Web Features. * Lays the groundwork for future features that rely on group-based organization and filtering. * Optimizes queries for features associated with a group and its descendants by pre-calculating and storing descendant group IDs. * This is useful because if a user queries for a group, it should return the features belonging to children groups too.
jcscottiii
force-pushed
the
jcscottiii/add-groups-table
branch
from
970e7a4
to
2cef527
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #593
Description:
This PR introduces the foundational schema and data access layer for managing WebDX Groups and their associations with Web Features in Spanner. This is the beginning of #299 to support only the groups storage and filtering. (Snapshot schema will come separately)
Key Changes
Schema:
WebDXGroupstable to store group metadata.WebFeatureGroupstable to map web features to their associated groups.WebDXGroupDescendantsto include the descendant group IDs for efficient queryingData Access Layer:
UpsertGroupandGetGroupIDFromGroupKeymethods in theClientstruct to interact with theWebDXGroupstable.UpsertWebFeatureGroupto manage feature-group mappings in theWebFeatureGroupstable.UpsertGroupDescendantInfoto manage mappings of groups to all descendant groups.WebFeatureGroup,groupSpannerMapper, etc.) to facilitate data mapping and persistence.Purpose