[3/4] Add Support for Group-Based Feature Search #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/add-group-term
branch
from
e59f646
to
e01a5b3
Compare
jcscottiii
changed the title
jcscottiii
force-pushed
the
jcscottiii/add-group-term
branch
from
e01a5b3
to
56650c8
Compare
jcscottiii
changed the title
dlaliberte
reviewed
Aug 16, 2024
| @@ -53,6 +54,7 @@ This query language enables you to construct flexible searches to find features | |||
| - `baseline_status:high` - Find features with a high baseline status. | |||
| - `name:"Dark Mode"` - Find features named "Dark Mode" (including spaces). | |||
| - `baseline_date:2023-01-01..2023-12-31` - Searches for all features that reached baseline in 2023. | |||
| - `group:css` - Searches for features that belong to the `css` group and any groups that are descendants of that group. | |||
There was a problem hiding this comment.
So every group name must be globally unique, including all the groups that are descendants of other groups? That might be problematic over time if different child group names would tend to be the same.
Maybe group names should use a path notation, always starting from the root. e.g. group:css.grid.
There was a problem hiding this comment.
Currently, the group ids are the filenames (without the suffix) in this directory. As a result, the ids are unique. But if they ever move to a directory based structure and nest the files, we would lose that guarantee, In that case, we could definitely revisit and do the group path idea.
dlaliberte
approved these changes
Aug 16, 2024
jcscottiii
force-pushed
the
jcscottiii/add-group-consumer
branch
from
e0ae53a
to
590b1a2
Compare
This PR enhances the feature search functionality by introducing a new `group` query term. Users can now search for features belonging to a specific group and any of its descendant groups in the web-features repository hierarchy. **New Query Functionality** * Query: `group:css` * Interpretation: Retrieves features belonging to the "css" group *and* any of its child or descendant groups (e.g., "grid"). **Implementation Details** * **Grammar Expansion:** The ANTLR4 grammar has been extended to include the `group` query term. * **Visitor Method:** A new `VisitGroup_term` method has been implemented to handle the parsing and generation of the intermediate representation for group queries. **Future Considerations** * While the current implementation includes descendant groups by default, future enhancements could allow users to optionally exclude descendants from the search results. **Benefits** * **Enhanced Search Capabilities:** Users can now perform more targeted searches based on the hierarchical organization of features within groups. * **Improved User Experience:** The new query term provides a more intuitive way to discover features related to a specific domain or area of interest.
jcscottiii
force-pushed
the
jcscottiii/add-group-term
branch
from
56650c8
to
641a869
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #595
This PR enhances the feature search functionality by introducing a new
groupquery term. Users can now search for features belonging to a specific group and any of its descendant groups in the web-features repository hierarchy.New Query Functionality
group:cssImplementation Details
groupquery term.VisitGroup_termmethod has been implemented to handle the parsing and generation of the intermediate representation for group queries.Future Considerations
Benefits