Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve documentation around Dockerfiles #70

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Improve documentation around Dockerfiles #70

merged 4 commits into from
Jul 16, 2020

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Jul 15, 2020

  • Fix the inline example in the cloud-run-http
  • Add a link to this sample Dockerfile in the main README

glasnt added 2 commits July 16, 2020 08:25
Useful for when this readme appears on both github and pypi
@di di merged commit 95d0b35 into GoogleCloudPlatform:master Jul 16, 2020
@di
Copy link
Member

di commented Jul 16, 2020

Thanks!

di pushed a commit that referenced this pull request Aug 11, 2020
* Add a link to an example Dockerfile in the top README.md

* Update the inline Dockerfile to match file

* Remove explicit gunicorn installation

* make readme links absolute, useful

Useful for when this readme appears on both github and pypi
di added a commit that referenced this pull request Oct 22, 2020
* Version 1.5.0 (#69)

* Revert "Version 2.0.0 (#67)"

This reverts commit f2471b4.

* Revert "Add Cloud Events support for #55 (#56) (#64)"

This reverts commit 8f3fe35.

* Version 1.5.0

* Improve documentation around Dockerfiles (#70)

* Add a link to an example Dockerfile in the top README.md

* Update the inline Dockerfile to match file

* Remove explicit gunicorn installation

* make readme links absolute, useful

Useful for when this readme appears on both github and pypi

* added cloudevents 1.0.0

Signed-off-by: Curtis Mason <cumason@google.com>

* reverted auto format

Signed-off-by: Curtis Mason <cumason@google.com>

* lint fixes

Signed-off-by: Curtis Mason <cumason@google.com>

* changed cloudevents to <=1.0 in setup

Signed-off-by: Curtis Mason <cumason@google.com>

* made cloudevents==1.0

Signed-off-by: Curtis Mason <cumason@google.com>

* added cloudevent_view tests

Signed-off-by: Curtis Mason <cumason@google.com>

* test lint fixes

Signed-off-by: Curtis Mason <cumason@google.com>

* implemented try_catch in cloudevent view wrapper

Signed-off-by: Curtis Mason <cumason@google.com>

* import fix

Signed-off-by: Curtis Mason <cumason@google.com>

* adjusted cloud_run_cloudevents readme

Signed-off-by: Curtis Mason <cumason@google.com>

* added elif for cloudevent

Signed-off-by: Curtis Mason <cumason@google.com>

* adjusted README

Signed-off-by: Curtis Mason <cumason@google.com>

* upgraded to cloudevents 1.0.1

Signed-off-by: Curtis Mason <cumason@google.com>

* import ordering lint fix

Signed-off-by: Curtis Mason <cumason@google.com>

* removed event from readme cloudevents section

Signed-off-by: Curtis Mason <cumason@google.com>

* resolved various nits and reverted event code

Signed-off-by: Curtis Mason <cumason@google.com>

* dockerfile env variables

Signed-off-by: Curtis Mason <cumason@google.com>

* Update examples/cloud_run_cloudevents/main.py

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Signed-off-by: Curtis Mason <cumason@google.com>

* cleaned up test_cloudevent_functions

Signed-off-by: Curtis Mason <cumason@google.com>

* Update examples/cloud_run_cloudevents/Dockerfile

Co-authored-by: Adam Ross <grayside@gmail.com>
Signed-off-by: Curtis Mason <cumason@google.com>

* tunneled cloud_exceptions in flask abort

Signed-off-by: Curtis Mason <cumason@google.com>

* Added additional documentation in sample code

Signed-off-by: Curtis Mason <cumason@google.com>

* added time to tests

Signed-off-by: Curtis Mason <cumason@google.com>

* Update README.md

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update README.md

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update README.md

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update README.md

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update examples/cloud_run_cloudevents/send_cloudevent.py

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update examples/cloud_run_cloudevents/README.md

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update examples/cloud_run_cloudevents/README.md

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update src/functions_framework/__init__.py

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* Update src/functions_framework/__init__.py

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* cloudevents 1.1.0 update

Signed-off-by: Curtis Mason <cumason@google.com>

* simplified exceptions debug

Signed-off-by: Curtis Mason <cumason@google.com>

* simplified cloudevent view test

Signed-off-by: Curtis Mason <cumason@google.com>

* Update src/functions_framework/__init__.py

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

* shebang cloudevent executable

Signed-off-by: Curtis Mason <cumason@google.com>

* cloudevents version bump

Signed-off-by: Curtis Mason <cumason@google.com>

* Removed InvalidStructuredJSON exception

Signed-off-by: Curtis Mason <cumason@google.com>

* Don't bump version in a feature branch

* Add back missing CHANGELOG lines

* Reformat with latest black

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Co-authored-by: Katie McLaughlin <glasnt@google.com>
Co-authored-by: Adam Ross <grayside@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants