Added cloudevent signature type using cloudevents sdk-python #78

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

di merged 50 commits into GoogleCloudPlatform:master from cumason123:cloudevents-1.0.0-refactor

Oct 22, 2020

Contributor

cumason123 commented Aug 13, 2020

Added signature type cloudevent which supports cloudevents 1.0.0

di and others added 8 commits

July 6, 2020 18:56


          Version 1.5.0 (GoogleCloudPlatform#69)

6f0d848

* Revert "Version 2.0.0 (GoogleCloudPlatform#67)"

This reverts commit f2471b4.

* Revert "Add Cloud Events support for GoogleCloudPlatform#55 (GoogleCloudPlatform#56) (GoogleCloudPlatform#64)"

This reverts commit 8f3fe35.

* Version 1.5.0


          Improve documentation around Dockerfiles (GoogleCloudPlatform#70)

95d0b35

* Add a link to an example Dockerfile in the top README.md

* Update the inline Dockerfile to match file

* Remove explicit gunicorn installation

* make readme links absolute, useful

Useful for when this readme appears on both github and pypi


          added cloudevents 1.0.0

ac48e64

Signed-off-by: Curtis Mason <cumason@google.com>


          reverted auto format

0d19c7f

Signed-off-by: Curtis Mason <cumason@google.com>


          lint fixes

000d83c

Signed-off-by: Curtis Mason <cumason@google.com>


          changed cloudevents to <=1.0 in setup

8f78a8b

Signed-off-by: Curtis Mason <cumason@google.com>


          made cloudevents==1.0

b9695ac

Signed-off-by: Curtis Mason <cumason@google.com>


          merged cloudevents from master into version-1.x-dev

9bad206

Signed-off-by: Curtis Mason <cumason@google.com>

google-cla bot added the cla: yes label

cumason123 changed the title ~~Cloudevents 1.0.0 refactor~~ Added cloudevent signature type using cloudevents sdk-python

cumason123 requested a review from grant

August 13, 2020 02:01

Curtis Mason added 4 commits

August 13, 2020 07:59


          added cloudevent_view tests

eb40068

Signed-off-by: Curtis Mason <cumason@google.com>


          test lint fixes

ab1b800

Signed-off-by: Curtis Mason <cumason@google.com>


          implemented try_catch in cloudevent view wrapper

19f066c

Signed-off-by: Curtis Mason <cumason@google.com>


          import fix

5b480ec

Signed-off-by: Curtis Mason <cumason@google.com>

Contributor Author

cumason123 commented Aug 13, 2020

Working on publishing cloudevents 1.0.1 for some quality of life changes within this PR

grant suggested changes

View reviewed changes

Contributor

grant left a comment

Overall looks good.

Be sure that this logic is purely incremental. We shouldn't touch the event signature. We can deduplicate logic that happens to be in that signature later.

tests/test_view_functions.py Outdated Show resolved Hide resolved

tests/test_view_functions.py Outdated Show resolved Hide resolved

tests/test_view_functions.py Outdated Show resolved Hide resolved

examples/cloud_run_cloudevents/README.md Show resolved Hide resolved

src/functions_framework/__init__.py Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Curtis Mason added 4 commits

August 13, 2020 12:01


          adjusted cloud_run_cloudevents readme

351bf58

Signed-off-by: Curtis Mason <cumason@google.com>


          added elif for cloudevent

9c323c9

Signed-off-by: Curtis Mason <cumason@google.com>


          adjusted README

9fc5a56

Signed-off-by: Curtis Mason <cumason@google.com>


          upgraded to cloudevents 1.0.1

a0d841b

Signed-off-by: Curtis Mason <cumason@google.com>

cumason123 requested review from grant and di

August 14, 2020 05:10


          import ordering lint fix

d48d0b9

Signed-off-by: Curtis Mason <cumason@google.com>

cumason123 requested a review from grayside

August 14, 2020 05:13

grant suggested changes

View reviewed changes

Contributor

grant left a comment

Looks good in general. Requested some changes.

README.md Outdated Show resolved Hide resolved

examples/cloud_run_cloudevents/README.md Outdated Show resolved Hide resolved

examples/cloud_run_cloudevents/README.md Outdated Show resolved Hide resolved

examples/cloud_run_cloudevents/main.py Outdated Show resolved Hide resolved

examples/cloud_run_cloudevents/main.py Outdated Show resolved Hide resolved

src/functions_framework/__init__.py Outdated Show resolved Hide resolved

src/functions_framework/__init__.py Outdated Show resolved Hide resolved

tests/test_cloudevent_functions.py Outdated Show resolved Hide resolved

tests/test_cloudevent_functions.py Show resolved Hide resolved

tests/test_functions/cloudevents/main.py Outdated Show resolved Hide resolved

di reviewed

View reviewed changes

examples/cloud_run_cloudevents/main.py Outdated Show resolved Hide resolved

Curtis Mason added 3 commits

August 14, 2020 12:20


          removed event from readme cloudevents section

cd2f753

Signed-off-by: Curtis Mason <cumason@google.com>


          resolved various nits and reverted event code

0d94485

Signed-off-by: Curtis Mason <cumason@google.com>


          dockerfile env variables

2b0a8ab

Signed-off-by: Curtis Mason <cumason@google.com>


          Don't bump version in a feature branch

5e17f8f

google-cla bot commented Sep 10, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla bot added cla: no and removed cla: yes labels


          Add back missing CHANGELOG lines

7477dea

google-cla bot commented Sep 10, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.


          Reformat with latest black

2d2413e

di added cla: yes and removed cla: no labels

google-cla bot commented Sep 10, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla bot added cla: no cla: yes and removed cla: yes cla: no labels


          Merge branch 'master' into cloudevents-1.0.0-refactor

15ad5a9

google-cla bot commented Sep 21, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla bot added cla: no and removed cla: yes labels

di added cla: yes and removed cla: no labels

di requested a review from asriniva

September 21, 2020 16:36

asriniva approved these changes

View reviewed changes


          Merge branch 'master' into cloudevents-1.0.0-refactor

7e16ae1

di removed the request for review from roffjulie

October 22, 2020 00:30

google-cla bot commented Oct 22, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla bot added cla: no and removed cla: yes labels

di added cla: yes and removed cla: no labels

di merged commit fccb88c into GoogleCloudPlatform:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels