Skip to content
This repository was archived by the owner on Apr 18, 2021. It is now read-only.

Need to change default registry option true => false #104

Closed
JhChoy opened this issue Mar 1, 2019 · 0 comments
Closed

Need to change default registry option true => false #104

JhChoy opened this issue Mar 1, 2019 · 0 comments
Assignees
@JhChoy
Labels
config About config files(service.vvisp.json, state.vvisp.json, .env etc) feature: deploy-service
Milestone
vvisp v1.0.0

Comments

@JhChoy
Copy link
Contributor

JhChoy commented Mar 1, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

In service.vvisp.json, default value of registry is true.

Expected behavior

Change it to false.

What is the motivation / use case for changing the behavior?

There are more cases that service uses nonUpgradeable contracts.
@JhChoy JhChoy added feature: deploy-service config About config files(service.vvisp.json, state.vvisp.json, .env etc) labels Mar 1, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Mar 1, 2019
@JhChoy JhChoy self-assigned this Mar 1, 2019
This was referenced Mar 1, 2019
Merged
Merged
JhChoy added a commit that referenced this issue Mar 2, 2019
@JhChoy
fix: fix default registry true => false (#107)
9d76bdd 
issued by #104
@JhChoy JhChoy closed this as completed Mar 2, 2019
JhChoy added a commit that referenced this issue Mar 3, 2019
@JhChoy
fix: fix default registry true => false (#107)
0548e70 
issued by #104
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@JhChoy JhChoy

Labels
config About config files(service.vvisp.json, state.vvisp.json, .env etc) feature: deploy-service
Projects
None yet
Milestone
vvisp v1.0.0
Development

No branches or pull requests
1 participant
@JhChoy