Skip to content
This repository was archived by the owner on Apr 18, 2021. It is now read-only.

fix: fix default registry true => false #107

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Conversation

JhChoy
Copy link
Contributor

@JhChoy JhChoy commented Mar 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #104

What is the new behavior?

Now, if you set like:

{
  "service": "Example",
  "contracts": {
  ...
  }
}

This means that your service does not need registry.

Does this PR introduce a breaking change?

  • Yes
  • No

@JhChoy JhChoy added feature: deploy-service config About config files(service.vvisp.json, state.vvisp.json, .env etc) labels Mar 1, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Mar 1, 2019
@JhChoy JhChoy self-assigned this Mar 1, 2019
@JhChoy JhChoy merged commit 9d76bdd into 1.0.0 Mar 2, 2019
@JhChoy JhChoy deleted the jay/fix-default-registry branch March 2, 2019 10:29
JhChoy added a commit that referenced this pull request Mar 3, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
config About config files(service.vvisp.json, state.vvisp.json, .env etc) feature: deploy-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants