Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

erlang 23.0 #54665

Closed
wants to merge 6 commits into from
Closed

Conversation

thelightcosine
Copy link

Created with brew bump-formula-pr.

@bayandin
Copy link
Member

resource "man" and resource "html" should be updated as well

@thelightcosine
Copy link
Author

@bayandin Done

chenrui333
chenrui333 previously approved these changes May 14, 2020
@chenrui333 chenrui333 self-requested a review May 14, 2020 04:03
@chenrui333
Copy link
Member

chenrui333 commented May 14, 2020

actually, we might need a legacy formula for the erlang@22.x

See previous upgrade (#39877)

@SMillerDev
Copy link
Member

I'd really rather we only make versioned formula when there's demand rather than for any update.

@bayandin
Copy link
Member

I've created a PR which will run tests on all erlang-dependant formula.
It should help us to decide if we need a versioned formula right now:
Homebrew/homebrew-test-bot#399

@bayandin
Copy link
Member

bayandin commented May 14, 2020

Changes to homebrew-test-bot have been merged.
I've deleted versioned formula to retrigger CI (sorry @chenrui333, I will revert it back if needed)

@bayandin
Copy link
Member

Error: 6 failed steps!
brew install --build-from-source couchdb
brew install --build-from-source ejabberd
brew install ejabberd
brew test --verbose rabbitmq
brew install --build-from-source wrangler
brew install --build-from-source yaws

@Bo98
Copy link
Member

Bo98 commented May 14, 2020

  • couchdb needs erlang@22: ERROR: OTP release 23 does not match required regex 19|20|21|22
  • ejabberd needs erlang@22: library not found for -lerl_interface ("The old legacy erl_interface library (functions with prefix erl_) is deprecated as of OTP 22, and will be removed in OTP 23. This does not apply to the ei library.")
  • rabbitmq needs investigating. 3.8.3 was supposed to work with OTP 23.
  • wrangler needs erlang@22: same error as ejabberd
  • yaws fails on a deprecation warning: yaws_config.erl:2071: ssl:cipher_suites/0 is deprecated and will be removed in OTP 24; use use cipher_suites/2,3 instead erlyaws/yaws#401 - can be patched to stop treating warnings as errors or it can use erlang@22.

@bayandin bayandin force-pushed the erlang-23.0 branch 2 times, most recently from 47a3526 to 2c7828a Compare May 15, 2020 21:14
@bayandin
Copy link
Member

ejabberd conflicts with couchdb:

The formula built, but is not symlinked into /usr/local
Could not symlink lib/jiffy-1.0.4/ebin/jiffy.app
Target /usr/local/lib/jiffy-1.0.4/ebin/jiffy.app
is a symlink belonging to couchdb. You can unlink it:
  brew unlink couchdb

To force the link and overwrite all conflicting files:
  brew link --overwrite ejabberd

To list all files that would be deleted:
  brew link --overwrite --dry-run ejabberd

Possible conflicting files are:
/usr/local/lib/jiffy-1.0.4/ebin/jiffy.app -> /usr/local/Cellar/couchdb/3.1.0_1/lib/jiffy-1.0.4/ebin/jiffy.app
/usr/local/lib/jiffy-1.0.4/ebin/jiffy.beam -> /usr/local/Cellar/couchdb/3.1.0_1/lib/jiffy-1.0.4/ebin/jiffy.beam
/usr/local/lib/jiffy-1.0.4/ebin/jiffy_utf8.beam -> /usr/local/Cellar/couchdb/3.1.0_1/lib/jiffy-1.0.4/ebin/jiffy_utf8.beam
/usr/local/lib/jiffy-1.0.4/priv/jiffy.so -> /usr/local/Cellar/couchdb/3.1.0_1/lib/jiffy-1.0.4/priv/jiffy.so

@bayandin
Copy link
Member

It's green now 🎉

@BrewTestBot
Copy link
Member

:shipit: @Bo98 has triggered a merge.

@bayandin
Copy link
Member

Thanks @thelightcosine!

@michaelklishin
Copy link
Contributor

FTR, the only known incompatibility with Erlang 23 in RabbitMQ 3.8.3 is around a memory allocator metric format change that breaks rabbitmq_prometheus. This has been addressed for 3.8.4 which should ship in about a week.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants