Toasts don't have correct CSS when used in frontend #254
Comments
|
I would like to start contributing to this project. I'm an experienced React developer and have worked with many of the libraries that you're using. Can I be assigned this as my first issue? Thanks. |
|
I ran both the front end repo and storybook locally. I found that on the front end repo, when I add a new patient, it shows a green toaster (which I think is correct?) whereas storybook shows a dark blue/grey success toaster. So they don't seem to match, but it seems that storybook is showing the wrong theme. Can somebody clarify? Thanks. |
|
Nice finding! Can you include the screenshot of both of them here? |
|
|
|
It may be worth taking a look at all of the toasters in storybook. I suspect a few of them may have the wrong colors. |
|
It seems that for many (all?) components in storybook, the 'default' color is bright green and the 'success' color is dark blue/grey. Perhaps the two are reversed? |
|
Also, I noticed that the "Design Choices" section of storybook is empty. Is there a place where we can see what the correct designs are? |
|
@DouglasDev the expected colors are the colors from the toasts found in the storybook. The frontend colors are not correct. |
|
@jackcmeyer I think this was fixed with this pull request: #581 |
…also relate to HospitalRun#254 HospitalRun#569) Ship components package with header injected styles (also relate to "fix HospitalRun#254" "fix HospitalRun#569"). We inject SCSS as <style> into <head> including bootstrap styles during the build process. This way we can skip shipping & referencing of .scss files. Please note: now that there's no need for a .scss references in the front-end, the main.scss reference in the front-end must be removed. BREAKING CHANGE: we skip shipping & referencing of main.scss files. Now that there's no need for a .scss references in the front-end, the main.scss reference in the front-end must be removed. "fix HospitalRun#254", "fix HospitalRun#569"
Ship components package with header injected styles (also relate to "fix #254" "fix #569"). We inject SCSS as <style> into <head> including bootstrap styles during the build process. This way we can skip shipping & referencing of .scss files. Please note: now that there's no need for a .scss references in the front-end, the main.scss reference in the front-end must be removed. BREAKING CHANGE: we skip shipping & referencing of main.scss files. Now that there's no need for a .scss references in the front-end, the main.scss reference in the front-end must be removed. "fix #254", "fix #569"
# [3.0.0](v2.0.1...v3.0.0) (2020-09-15) ### Bug Fixes * **component:** ship components package with header injected styles ([afee9ff](afee9ff)), closes [#254](#254) [#569](#569) [#254](#254) [#569](#569) ### BREAKING CHANGES * **component:** we skip shipping & referencing of main.scss files. Now that there's no need for a .scss references in the front-end, the main.scss reference in the front-end must be removed.
|
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
🐛 Bug Report
Toasts (such as after adding a new Patient) do not have the correct theme colors applied when used in hospitalrun-frontend. This is probably an error in the build settings for the components library. Originally reported in HospitalRun/hospitalrun-frontend#1764
To Reproduce
Compare the Success toast from the components storybook https://components.hospitalrun.io/, to the one that appears when adding a new Patient from the frontend https://staging.hospitalrun.io/.
Expected behavior
Colors in frontend match colors in components storybook.
The text was updated successfully, but these errors were encountered: