Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(scss): callout & toaster styles not working #581

Merged
merged 3 commits into from
Sep 8, 2020
Merged

fix(scss): callout & toaster styles not working #581

merged 3 commits into from
Sep 8, 2020

Conversation

DouglasDev
Copy link
Contributor

@DouglasDev DouglasDev commented Sep 8, 2020 •
edited
Loading

Fixes #569

Changes proposed in this pull request:

  • import scss for components into main.scss
  • remove unnecessary scss imports

@jackcmeyer jackcmeyer added the bug Something isn't working label Sep 8, 2020
@DouglasDev DouglasDev changed the title Bug/callout scss Fix: component scss import Sep 8, 2020
@jackcmeyer jackcmeyer changed the title Fix: component scss import fix(scss): fixes callout & toaster styles not working Sep 8, 2020
@DouglasDev DouglasDev changed the title fix(scss): fixes callout & toaster styles not working Fix: component scss imports Sep 8, 2020
@DouglasDev DouglasDev changed the title Fix: component scss imports fixes callout & toaster styles not working Sep 8, 2020
@jackcmeyer jackcmeyer changed the title fixes callout & toaster styles not working fix(scss): callout & toaster styles not working Sep 8, 2020
fox1t
fox1t approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the idea of having just one "entrypoint" for the scss files.

@fox1t fox1t merged commit 7cb8484 into HospitalRun:master Sep 8, 2020
@ghost
Copy link

ghost commented Sep 8, 2020

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Sep 8, 2020
blestab
blestab reviewed Sep 8, 2020
View reviewed changes
Copy link

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DouglasDev DouglasDev mentioned this pull request Sep 8, 2020
Closed
@jackcmeyer jackcmeyer mentioned this pull request Sep 8, 2020
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@blestab blestab blestab left review comments

@fox1t fox1t fox1t approved these changes

@jackcmeyer jackcmeyer Awaiting requested review from jackcmeyer

@morrme morrme Awaiting requested review from morrme

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callout css does not work when importing to frontend
5 participants
@DouglasDev @fox1t @blestab @CreativeCreate @jackcmeyer