Resolve spelling issues #99
Labels
Milestone
Comments
Ianleeclark
added a commit
that referenced
this issue
Apr 23, 2016
Merged
Ianleeclark
pushed a commit
that referenced
this issue
Apr 23, 2016
Ianleeclark
pushed a commit
that referenced
this issue
Apr 24, 2016
* Update README.md * Adding a circle.yml Maybe this'll build the docker image. * Create appveyor.yml * Delete appveyor.yml * Delete circle.yml * Update Dockerfile * Update config.go * Resolves #85 * Issue #85 Updating peer retrieval to take 30 random peers from complete. Need to update redis.go * Issue #85 Updating Redis.go to fetch random peers * Update server.go * Update redis.go * Update .travis.yml * Update redis.go * Fixes #93 (#95) * Update .travis.yml * Fix gofmt and some golint issues (#91) * Issue #93 CHANGE: - Too many things to list individually but there's a hell of a lot of linter-friendly code. Probably didn't increase code quality and maybe lowered it, but sometimes you gotta do what you gotta do * Issue #93: Merging origin/devel into origin/issue-93 * Issue #96: Adding some unit tests to redis.go * Adding redis service to travis. * Issue #96 ADD: - redis.go:RedisGetBoolKeyVal() Now checks redis.Exists() and bases the return value off of that. - redis_test.go: A few more unit tests, almost done * Issue #96 ADD: - redis_test.go Added remaining unit tests, probably near 100% unit coverage but who cares. * Issue #96 CHANGE: - server/redis_test.go:TestRedisSetKeyIfNotExists() fixed dysfunctional test, we expect a return to false because the key doesn't redis.Exist() * Issue #96: Adding some unit tests to redis.go (#98) * Issue #96: Adding some unit tests to redis.go * Adding redis service to travis. * Issue #96 ADD: - redis.go:RedisGetBoolKeyVal() Now checks redis.Exists() and bases the return value off of that. - redis_test.go: A few more unit tests, almost done * Issue #96 ADD: - redis_test.go Added remaining unit tests, probably near 100% unit coverage but who cares. * Issue #96 CHANGE: - server/redis_test.go:TestRedisSetKeyIfNotExists() fixed dysfunctional test, we expect a return to false because the key doesn't redis.Exist() * Issue #96 CHANGE: - Just fixing issues created by the merge * Issue #99 (#100) CHANGE: - server/announce.go: Fixed mispelling "happend" -> "happened" * Issue #94 (#101) ADD: - bencode/bencode.go:writeStringData() New function to concatenate two strings more efficiently than our older Sprintf method. Not a big deal, but every part matters. * Issue #97 (#102) CHANGE: - redis.go: Changed any instance where redis.go functions expected a `redisClient` and a *announceData as two seperate paramters, to only expect on `data *announceData` * [WIP] Issue #103 (#104) * Issue #103 ADD: - server/definitions.go:applicationContext a new data structure that represents data that should persist in that form throughout the entire application's lifetime. - server/definitions.go:requestAppContext a new data structure representing data that needs to persist only for a peer data transaction (database connections, redis connections, potentially more in the future.) * Issue #103 CHANGE: - All changes associated with this commit are changing `announceData` to have a `requestContext` member (of type requestAppContext) instead of a `redisClient` member.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
https://goreportcard.com/report/github.com/GrappigPanda/notorious#misspell
The text was updated successfully, but these errors were encountered: