[WIP] Release 0.3.0 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ianleeclark
commented
Apr 1, 2016
•
Ianleeclark
commented
- Fixes Pass config to the requestHandler #103 (conifg-> requestHandler)
- Fixes Resolve spelling issues #99 (Fix spelling issues)
- Fixes Update redis.go to accept announceData in place of both announceData and redis.Clients #97 (Reduce passing of *announceData to once per redis func call)
- Fixes Unit test redis.go #96 (Add tests for redis.go)
- Fixes Improve bencode library #94 (Improve bencode encoding)
- Fixes Go vet and go lint Notorious #93 (Go vet and go lint)
- Fixes Benchmark performance between different http routers #92 (benchmark performance)
- Fixes If number of peer > data.numwant, tracker should return peer randomly #85 (Random peer selection)
- Fixes Move unit test coverage to incorporate coveralls.io and goveralls #12 (Use coveralls for coverage?)
Maybe this'll build the docker image.
* Update .travis.yml * Fix gofmt and some golint issues (#91) * Issue #93 CHANGE: - Too many things to list individually but there's a hell of a lot of linter-friendly code. Probably didn't increase code quality and maybe lowered it, but sometimes you gotta do what you gotta do * Issue #93: Merging origin/devel into origin/issue-93
* Issue #96: Adding some unit tests to redis.go * Adding redis service to travis. * Issue #96 ADD: - redis.go:RedisGetBoolKeyVal() Now checks redis.Exists() and bases the return value off of that. - redis_test.go: A few more unit tests, almost done * Issue #96 ADD: - redis_test.go Added remaining unit tests, probably near 100% unit coverage but who cares. * Issue #96 CHANGE: - server/redis_test.go:TestRedisSetKeyIfNotExists() fixed dysfunctional test, we expect a return to false because the key doesn't redis.Exist() * Issue #96 CHANGE: - Just fixing issues created by the merge
|
I'm going to strip out any sql-related things from this besides passing the config to the requestHandler and make the next milestone a huge SQL update. |
* Issue #103 ADD: - server/definitions.go:applicationContext a new data structure that represents data that should persist in that form throughout the entire application's lifetime. - server/definitions.go:requestAppContext a new data structure representing data that needs to persist only for a peer data transaction (database connections, redis connections, potentially more in the future.) * Issue #103 CHANGE: - All changes associated with this commit are changing `announceData` to have a `requestContext` member (of type requestAppContext) instead of a `redisClient` member.
|
Cancelling #12. Not being able to cover multiple packages is exceptionally dumb. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.