COMP: Remove spare closing bracket #5259
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove spare closing bracket. Left behind inadvertently in commit 2bd9f0a. Fixes: ``` T:\Dashboard\ITK\Modules\Filtering\GPUAnisotropicSmoothing\include\itkGPUAnisotropicDiffusionImageFilter.hxx(66,76): error C2187: syntax error: ')' was unexpected here [T:\Dashboard\ITK-build\Modules\Filtering\GPUAnisotropicSmoothing\ITKGPUAnisotropicSmoothingHeaderTest1.vcxproj] ``` raised for example in: https://open.cdash.org/viewBuildError.php?buildid=10232159
jhlegarreta
requested review from
hjmjohnson,
blowekamp,
dzenanz and
N-Dekker
|
Have not tried to build locally. |
github-actions
bot
added
type:Compiler
dzenanz
approved these changes
Feb 27, 2025
N-Dekker
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Thanks Jon! I see, my fault, sorry! 🤷
- For the record, the flaw was introduced by pull request STYLE: Replace
std::pow(2, dim)calls with1 << dim#5252 commit 2bd9f0a
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove spare closing bracket.
Left behind inadvertently in commit 2bd9f0a.
Fixes:
raised for example in:
https://open.cdash.org/viewBuildError.php?buildid=10232159
PR Checklist