Fixed sending issue with token overload #36
Conversation
- Fixes #32 Updated non-breaking dependencies in NuGet packages
WalkthroughThis pull request focuses on updating package references in the SendGrid email utility project and modifying the Changes
Assessment against linked issues
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/NetCore.Utilities.Email.SendGrid.Tests/NetCore.Utilities.Email.SendGrid.Tests.csproj(1 hunks)src/NetCore.Utilities.Email.SendGrid/NetCore.Utilities.Email.SendGrid.csproj(1 hunks)src/NetCore.Utilities.Email.SendGrid/SendGridService.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
src/NetCore.Utilities.Email.SendGrid/SendGridService.cs (1)
61-61: LGTM! Token handling fix properly implemented.The change correctly propagates the tokens parameter instead of passing null, fixing the token overload issue.
src/NetCore.Utilities.Email.SendGrid/NetCore.Utilities.Email.SendGrid.csproj (1)
43-47: LGTM! Package updates align with project requirements.
- SendGrid update (9.29.2 → 9.29.3) is a patch version, likely containing bug fixes
- Microsoft.SourceLink.GitHub update (1.1.1 → 8.0.0) aligns with net8.0 target framework
| <PackageReference Include="coverlet.collector" Version="6.0.4"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.3.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" /> | ||
| <PackageReference Include="Moq" Version="4.20.70" /> | ||
| <PackageReference Include="xunit" Version="2.7.0" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.5.7"> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" /> | ||
| <PackageReference Include="Moq" Version="4.20.72" /> | ||
| <PackageReference Include="xunit" Version="2.9.3" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="3.0.1"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> |
There was a problem hiding this comment.
💡 Codebase verification
Microsoft.AspNetCore.Hosting.Abstractions 2.3.0 is incompatible with .NET 8.0
This package version is from the ASP.NET Core 2.x era and is not compatible with .NET 8.0. For .NET 8.0 projects:
- Remove the explicit reference to
Microsoft.AspNetCore.Hosting.Abstractions - These abstractions are now part of the
Microsoft.AspNetCore.Appshared framework in .NET 8.0
🔗 Analysis chain
Verify compatibility of Microsoft.AspNetCore.Hosting.Abstractions upgrade.
While most package updates are minor versions or patches, the jump from 2.2.0 to 2.3.0 for Microsoft.AspNetCore.Hosting.Abstractions is significant. Let's verify its compatibility with net8.0.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check package compatibility with net8.0
# Check if Microsoft.AspNetCore.Hosting.Abstractions 2.3.0 supports net8.0
curl -s "https://api.nuget.org/v3/registration5-gz-semver2/microsoft.aspnetcore.hosting.abstractions/2.3.0.json" | jq -r '.catalogEntry.dependencyGroups[].targetFramework'
# Check for any reported issues with this version
gh api graphql -f query='
{
repository(owner: "dotnet", name: "aspnetcore") {
issues(first: 5, filterBy: {labels: ["area/hosting"], states: OPEN}) {
nodes {
title
url
labels(first: 5) {
nodes {
name
}
}
}
}
}
}'
Length of output: 585
Script:
#!/bin/bash
# Description: Verify package information using nuget.org API
# Check package versions
curl -s "https://api.nuget.org/v3/registration5-gz-semver2/microsoft.aspnetcore.hosting.abstractions/index.json" | jq -r '.items[].items[].catalogEntry.version'
# Get more details about version 2.3.0
curl -s "https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.hosting.abstractions/index.json" | jq -r '.versions[]' | sort -V
Length of output: 672
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release-build.yml (1)
24-24: Remove trailing whitespace.There are trailing spaces on this line.
- dotnet-version: 8.0.x - + dotnet-version: 8.0.x🧰 Tools
🪛 yamllint (1.35.1)
[error] 24-24: trailing spaces
(trailing-spaces)
.github/workflows/ci-build.yml (1)
25-25: Remove trailing whitespace.There are trailing spaces on this line.
- dotnet-version: 8.0.x - + dotnet-version: 8.0.x🧰 Tools
🪛 yamllint (1.35.1)
[error] 25-25: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-build.yml(1 hunks).github/workflows/release-build.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/ci-build.yml
[error] 25-25: trailing spaces
(trailing-spaces)
.github/workflows/release-build.yml
[error] 24-24: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
.github/workflows/release-build.yml (2)
26-28: LGTM! Improved version pinning.The change from
6.xto6.0.5for GitVersion improves build reproducibility by pinning to a specific version.
21-21: Verify compatibility with setup-dotnet@v4.The upgrade from v3 to v4 of setup-dotnet is a major version bump that could introduce breaking changes. While v4 is the latest stable version with .NET 8 support, we should verify its compatibility.
Run this script to check the changelog and any known issues:
Also applies to: 26-28, 32-32
✅ Verification successful
The upgrade to setup-dotnet@v4 is safe to proceed
The breaking changes in v4 are internal improvements that actually enhance reliability, particularly for version installations. Your usage of .NET 8.0.x is well-supported in v4. While there are some open issues with v4, they don't affect your specific setup.
Note: Monitor the first few workflow runs after the upgrade, as there's an open issue (#588) about URL changes affecting some workflows.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for breaking changes in setup-dotnet v4 # Fetch the changelog and release notes curl -s https://api.github.com/repos/actions/setup-dotnet/releases | jq -r '.[] | select(.tag_name=="v4.0.0") | .body' # Check for any reported issues related to v4 migration gh api graphql -f query=' { search(query: "repo:actions/setup-dotnet is:issue label:bug v4", type: ISSUE, first: 5) { nodes { ... on Issue { title url state } } } }'Length of output: 3228
Script:
#!/bin/bash # Check .NET version specifications and global.json echo "Checking .NET version specifications in workflow files:" fd -e yml -e yaml . .github/workflows --exec grep -l "dotnet-version" echo -e "\nChecking for global.json files:" fd global.json echo -e "\nIf global.json exists, show its content:" fd global.json -x cat {} echo -e "\nChecking specific .NET version patterns in workflow files:" fd -e yml -e yaml . .github/workflows --exec grep -A 1 -B 1 "dotnet-version"Length of output: 791
.github/workflows/ci-build.yml (1)
22-22: LGTM! Consistent workflow configurations.The version updates in the CI workflow match those in the release workflow, maintaining consistency across the build pipeline:
- Upgrade to setup-dotnet@v4
- Update to gittools/actions v3.1.11
- Pin GitVersion to 6.0.5
Also applies to: 27-29, 33-33
Updated non-breaking dependencies in NuGet packages
Summary by CodeRabbit
Package Updates
coverlet.collector,Microsoft.AspNetCore.Hosting.Abstractions,Microsoft.NET.Test.Sdk,Moq,xunit, andxunit.runner.visualstudioto their latest versionsSendGridandMicrosoft.SourceLink.GitHubpackage versionsCode Improvements
SendMessageAsyncmethod to better handle token replacements in email messagesCI/CD Enhancements