Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed sending issue with token overload #36

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixed sending issue with token overload #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
425221d
Fixed sending issue with token overload
mitchelsellers Jan 26, 2025
0faedcd
Fixed builds
mitchelsellers Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ jobs:
fetch-depth: 0

- name: Ensure .NET Installed
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x

- name: Install GitVersion
uses: gittools/actions/gitversion/setup@v3.0.0
uses: gittools/actions/gitversion/setup@v3.1.11
with:
versionSpec: '6.x'
versionSpec: '6.0.5'

- name: Determine Version
id: gitversion
uses: gittools/actions/gitversion/execute@v3.0.0
uses: gittools/actions/gitversion/execute@v3.1.11
with:
useConfigFile: true

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ jobs:
fetch-depth: 0

- name: Ensure .NET Installed
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x

- name: Install GitVersion
uses: gittools/actions/gitversion/setup@v3.0.0
uses: gittools/actions/gitversion/setup@v3.1.11
with:
versionSpec: '6.x'
versionSpec: '6.0.5'

- name: Determine Version
id: gitversion
uses: gittools/actions/gitversion/execute@v3.0.0
uses: gittools/actions/gitversion/execute@v3.1.11
with:
useConfigFile: true

Expand Down
12 changes: 6 additions & 6 deletions src/NetCore.Utilities.Email.SendGrid.Tests/NetCore.Utilities.Email.SendGrid.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="6.0.2">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.2.0" />
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.3.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="Moq" Version="4.20.70" />
<PackageReference Include="xunit" Version="2.7.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Comment on lines +10 to 23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Microsoft.AspNetCore.Hosting.Abstractions 2.3.0 is incompatible with .NET 8.0

This package version is from the ASP.NET Core 2.x era and is not compatible with .NET 8.0. For .NET 8.0 projects:

  • Remove the explicit reference to Microsoft.AspNetCore.Hosting.Abstractions
  • These abstractions are now part of the Microsoft.AspNetCore.App shared framework in .NET 8.0
🔗 Analysis chain

Verify compatibility of Microsoft.AspNetCore.Hosting.Abstractions upgrade.

While most package updates are minor versions or patches, the jump from 2.2.0 to 2.3.0 for Microsoft.AspNetCore.Hosting.Abstractions is significant. Let's verify its compatibility with net8.0.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check package compatibility with net8.0

# Check if Microsoft.AspNetCore.Hosting.Abstractions 2.3.0 supports net8.0
curl -s "https://api.nuget.org/v3/registration5-gz-semver2/microsoft.aspnetcore.hosting.abstractions/2.3.0.json" | jq -r '.catalogEntry.dependencyGroups[].targetFramework'

# Check for any reported issues with this version
gh api graphql -f query='
{
  repository(owner: "dotnet", name: "aspnetcore") {
    issues(first: 5, filterBy: {labels: ["area/hosting"], states: OPEN}) {
      nodes {
        title
        url
        labels(first: 5) {
          nodes {
            name
          }
        }
      }
    }
  }
}'

Length of output: 585

Script:

#!/bin/bash
# Description: Verify package information using nuget.org API

# Check package versions
curl -s "https://api.nuget.org/v3/registration5-gz-semver2/microsoft.aspnetcore.hosting.abstractions/index.json" | jq -r '.items[].items[].catalogEntry.version'

# Get more details about version 2.3.0
curl -s "https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.hosting.abstractions/index.json" | jq -r '.versions[]' | sort -V

Length of output: 672

Expand Down
4 changes: 2 additions & 2 deletions src/NetCore.Utilities.Email.SendGrid/NetCore.Utilities.Email.SendGrid.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Options" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="8.0.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="SendGrid" Version="9.29.2" />
<PackageReference Include="SendGrid" Version="9.29.3" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/NetCore.Utilities.Email.SendGrid/SendGridService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public Task<bool> SendMessageAsync(string toAddress, string subject, string body
public Task<bool> SendMessageAsync(string toAddress, string subject, string bodyHtml,
List<KeyValuePair<string, string>> tokens)
{
return SendMessageAsync(toAddress, null, subject, bodyHtml, null, "");
return SendMessageAsync(toAddress, null, subject, bodyHtml, tokens, "");
}

/// <inheritdoc />
Expand Down
Loading