Add compress option to saveProject #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that they *do not* reccommend storing files compressed there we make
the `compress` option, which gets passed on to `base::save` configurable
in `saveProject`.
Also given we call this method indirectly from so many methods if not explicitly provided
then we check the global options `options("rgcam.saved_compressed")` and if
that is not set we fall back to the default behavior which continues to be "xz".
the the other readr bug has now made it into a release so we can put those tests back in.
Codecov Report
|
kvcalvin
approved these changes
Nov 19, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
saveProjectruns incredibly slow on PIC's lustre filesystem and that they do not recommend storing files compressed there we makethe
compressoption, which gets passed on tobase::saveconfigurablein
saveProject.Also given we call this method indirectly from so many methods if not explicitly provided
then we check the global options
options("rgcam.saved_compressed")and ifthat is not set we fall back to the default behavior which continues to be "xz".