-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove engine code that reads in position and orientation #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I'd suggest using the method Element::ReadFrom
in the warning messages to help the user locating the origin of the warnings.
Also the test The changes I have suggested above for the C++ code of the PR should help locating these now useless elements |
Correct, I was planning on doing that next once this pull request is approved and merged in. |
All right. |
…m#559) The engine position and orientation data is read in but isn't used, it's only the thruster's location and orientation that matter, which causes confusion.
…s. (JSBSim-Team#561) This is linked to the PR JSBSim-Team#559.
As mentioned in #547 (comment) the engine position and orientation data is read in but isn't used, it's only the thruster's location and orientation that matter, which causes confusion.