-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Brushless electric motor example #573
Conversation
FRBLDC_first_release
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
@pbecchi I'm not sure how you're generating the pull request overall. When I took an initial look at the list of commits it lists 31 commits, I'm pretty sure the 31 commits weren't all relevant to simply adding the new quadcopter model. Also when I take a look at the files changed in addition to the files added for the quadcopter I noticed Just generally makes things more confusing to review. Compare it to this pull request - #559 where there was a single commit on Jan 6 when the pull request was created and then after feedback from @bcoconni on the pull request I pushed another commit on Jan 7 to this branch/pull request. So only the relevant commits show up in the pull request, and not 31 commits (https://github.com/JSBSim-Team/jsbsim/pull/573/commits) and also only the relevant files. My workflow when generating a pull request like the example above is to first merge the latest Once the pull request is merged into When we merge in the pull request we perform a |
This PR should consist on only one commit: c137c20
|
This is DJI F450 quadcopter example to test behaviour of new brushless DC electric motor.