Avoid non physical values for the ambient pressure and temperature

[bcoconni]

This PR is addressing the bugs reported in the issue #815. As discussed, it caps pressure and temperature to small values:

• 1K which is, according to Wikipedia, the temperature at the coolest natural place currently known in the Universe.
• 1E-15Pa which is, according to Wikipedia, the pressure in outer space between stars in the Milky Way

JSBSim caps the pressure and temperature to the above mentioned values, issues an error message and continues execution.

I took this opportunity to add checks for other seting methods in FGAtmosphere and FGStandardAtmosphere.

[codecov]

Codecov Report

Merging #836 (637cd1d) into master (ec99f79) will increase coverage by 0.05%.
The diff coverage is 18.29%.

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   22.37%   22.43%   +0.05%     
==========================================
  Files         167      167              
  Lines       19535    19600      +65     
==========================================
+ Hits         4371     4397      +26     
- Misses      15164    15203      +39     

Impacted Files	Coverage Δ
src/models/FGAtmosphere.h	78.94% <ø> (ø)
src/models/atmosphere/FGStandardAtmosphere.cpp	53.61% <1.81%> (-7.47%)	⬇️
src/models/FGAtmosphere.cpp	53.80% <51.85%> (+9.80%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[seanmcleod]

@agodemar I had a pending code review comment/suggestion for @bcoconni that he hadn't replied to yet.

[bcoconni]

Sorry @seanmcleod but I can't find your code review. Could you remind me what were the modifications that you were suggesting ?

[seanmcleod]

Hi @bcoconni but they appear just above if you visit the URL for this pull request - #836

Do they not show for you?

[bcoconni]

Hi @bcoconni but they appear just above if you visit the URL for this pull request - #836

Do they not show for you?

I'm afraid not. Below is a screen capture of what I'm seeing.
May be there remains a GitHub button that you didn't push ?

[seanmcleod]

Hmm, I'll take a look, in the meantime this is what I see.

It says Pending but I assumed that means it was pending feedback from you.

[bcoconni]

Hmm, I'll take a look, in the meantime this is what I see.

It says Pending but I assumed that means it was pending feedback from you.

It seems it is pending for you according to the GitHub docs:

Before you submit your review, your line comments are pending and only visible to you. You can edit pending comments anytime before you submit your review. To cancel a pending review, including all of its pending comments, scroll down to the end of the timeline on the Conversation tab, then click Cancel review.

The last steps you need to follow are described in the GitHub docs: Submitting your review