Clarify the code intent #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean McLeod <sean@seanmcleod.com>
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 22.43% 22.43%
=======================================
Files 167 167
Lines 19600 19610 +10
=======================================
+ Hits 4397 4400 +3
- Misses 15203 15210 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@bcoconni looks good! |
|
Great 👍 PR merged. |
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Apr 8, 2023
Co-authored-by: Sean McLeod <sean@seanmcleod.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account @seanmcleod's comments that were made in the PR #836.
The method
FGTable::GetMinValue()has been created in the process to extract the minimum temperature fromStdAtmosTemperatureTable.