Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prohibit more than one connections to the same shared database #2024

Merged
merged 2 commits into from
Sep 22, 2016
Merged

Prohibit more than one connections to the same shared database #2024

merged 2 commits into from
Sep 22, 2016

Conversation

obraliar
Copy link
Contributor

@obraliar obraliar commented Sep 21, 2016 •
edited
Loading

Bonus extension to #970.

⚠️ Depends on #2009. Do not merge before #2009 gets merged in.

Screenshot:

snapshot4

  • Internal quality assurance
  • Change in CHANGELOG.md described
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@obraliar
Prohibit more than one connections to the same shared database.
6cddecc 
- Add equals method to DBMSConnectionProperties
- Add verification methods to OpenSharedDatabaseDialog
- Update localization keys
@obraliar obraliar force-pushed the ProhibitMoreThanOneConnectionsToTheSameDatabase branch from 629d8d7 to 6cddecc Compare September 22, 2016 16:26
@boceckts boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Sep 22, 2016
@boceckts boceckts changed the title [WIP] Prohibit more than one connections to the same shared database Prohibit more than one connections to the same shared database Sep 22, 2016
@obraliar obraliar force-pushed the ProhibitMoreThanOneConnectionsToTheSameDatabase branch 2 times, most recently from 26c1e3a to a439c9a Compare September 22, 2016 22:05
@obraliar
Merge remote tracking branch 'upstream/master'
a439c9a 
Fix Conflicts:
	CHANGELOG.md
	src/main/java/net/sf/jabref/shared/DBMSConnectionProperties.java
@koppor koppor merged commit 9644bb3 into JabRef:master Sep 22, 2016
zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016
@obraliar @zesaro
Prohibit more than one connections to the same shared database. (JabR…
e3cb6e4 
…ef#2024)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obraliar @koppor @tschechlovdev @boceckts