Prohibit more than one connections to the same shared database

CHANGELOG.md

@@ -43,6 +43,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - Importer for MODS format added
 - [#2012](https://github.com/JabRef/jabref/issues/2012) Implemented integrity check for `month` field: Should be an integer or normalized (BibLaTeX), Should be normalized (BibTeX)
 - [#1779](https://github.com/JabRef/jabref/issues/1779) Implemented integrity check for `bibtexkey` field: Empty bibtexkey
+- Prohibit more than one connections to the same shared database.
 
 ### Fixed
 - Fixed selecting an entry out of multiple duplicates

src/main/java/net/sf/jabref/gui/shared/OpenSharedDatabaseDialog.java

@@ -9,6 +9,7 @@
 import java.io.UnsupportedEncodingException;
 import java.security.GeneralSecurityException;
 import java.sql.SQLException;
+import java.util.List;
 import java.util.Optional;
 import java.util.Set;
 
@@ -30,6 +31,8 @@
 
 import net.sf.jabref.Globals;
 import net.sf.jabref.JabRefException;
+import net.sf.jabref.JabRefGUI;
+import net.sf.jabref.gui.BasePanel;
 import net.sf.jabref.gui.JabRefFrame;
 import net.sf.jabref.gui.help.HelpAction;
 import net.sf.jabref.logic.help.HelpFile;
@@ -94,6 +97,14 @@ public OpenSharedDatabaseDialog(JabRefFrame frame) {
     }
 
     public void openSharedDatabase() {
+
+        if (isSharedDatabaseAlreadyPresent()) {
+            JOptionPane.showMessageDialog(OpenSharedDatabaseDialog.this,
+                    Localization.lang("You are already connected to a database using entered connection details."),
+                    Localization.lang("Warning"), JOptionPane.WARNING_MESSAGE);
+            return;
+        }
+
         setLoadingConnectButtonText(true);
 
         try {
@@ -368,4 +379,18 @@ private void setLoadingConnectButtonText(boolean isLoading) {
         }
     }
 
+    /**
+     * Checks whether a database with the given @link {@link DBMSConnectionProperties} is already opened.
+     */
+    private boolean isSharedDatabaseAlreadyPresent() {
+        List<BasePanel> panels = JabRefGUI.getMainFrame().getBasePanelList();
+        for (BasePanel panel : panels) {
+            DBMSConnectionProperties dbmsConnectionProperties = panel.getBibDatabaseContext().getDBMSSynchronizer()
+                    .getDBProcessor().getDBMSConnectionProperties();
+            if (this.connectionProperties.equals(dbmsConnectionProperties)) {
+                return true;
+            }
+        }
+        return false;
+    }
 }

src/main/java/net/sf/jabref/shared/DBMSConnectionProperties.java

@@ -91,6 +91,17 @@ public void setPassword(String password) {
         this.password = password;
     }
 
+    /**
+     * Compares all properties except the password.
+     */
+    public boolean equals(DBMSConnectionProperties properties) {
+        return this.type.equals(properties.getType())
+                && this.host.equalsIgnoreCase(properties.getHost())
+                && this.port == properties.getPort()
+                && this.database.equals(properties.getDatabase())
+                && this.user.equals(properties.getUser());
+    }
+
     /**
      *  Gets all required data from {@link SharedDatabasePreferences} and sets them if present.
      */

src/main/java/net/sf/jabref/shared/DBMSProcessor.java

@@ -566,6 +566,10 @@ public static DBMSProcessor getProcessorInstance(DBMSConnection connection) {
         return null; // can never happen except new types were added without updating this method.
     }
 
+    public DBMSConnectionProperties getDBMSConnectionProperties() {
+        return this.connectionProperties;
+    }
+
     /**
      * Listens for notifications from DBMS.
      * Needs to be implemented if LiveUpdate is supported by the DBMS

src/main/resources/l10n/JabRef_da.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_de.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=Eine_Datenbankverbindung_mit_den_eingegebenen_Verbindungsinformationen_besteht_bereits.

src/main/resources/l10n/JabRef_en.properties

@@ -2246,6 +2246,8 @@ Shared_entry_is_no_longer_present=Shared_entry_is_no_longer_present
 The_BibEntry_you_currently_work_on_has_been_deleted_on_the_shared_side.=The_BibEntry_you_currently_work_on_has_been_deleted_on_the_shared_side.
 You_can_restore_the_entry_using_the_"Undo"_operation.=You_can_restore_the_entry_using_the_"Undo"_operation.
 Remember_password?=Remember_password?
+You_are_already_connected_to_a_database_using_entered_connection_details.=You_are_already_connected_to_a_database_using_entered_connection_details.
+
 Cannot_cite_entries_without_BibTeX_keys._Generate_keys_now?=Cannot_cite_entries_without_BibTeX_keys._Generate_keys_now?
 New_technical_report=New_technical_report
 

src/main/resources/l10n/JabRef_es.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_fa.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_fr.properties

@@ -2298,4 +2298,5 @@ Invalid_ISBN\:_'%0'.=ISBN_invalide_:_%0.
 should_be_an_integer_or_normalized=devrait_être_un_entier_ou_une_abréviation_standard
 should_be_normalized=devrait_être_une_abréviation_standard
 
+You_are_already_connected_to_a_database_using_entered_connection_details.=
 empty_bibtexkey=Clef_BibTeX_vide

src/main/resources/l10n/JabRef_in.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_it.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_ja.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_nl.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_no.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_pt_BR.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_ru.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_sv.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_tr.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_vi.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=

src/main/resources/l10n/JabRef_zh.properties

@@ -2299,3 +2299,4 @@ should_be_an_integer_or_normalized=
 should_be_normalized=
 
 empty_bibtexkey=
+You_are_already_connected_to_a_database_using_entered_connection_details.=