This repository has been archived by the owner on Jul 13, 2021. It is now read-only.
fix ssao rendering issue in LScene and update lighting docs #624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs update for JuliaPlots/GLMakie.jl#107.
Also fixes this issue with ssao in figures:
Currently SSAO distinguishes between scenes using a stencil buffer that is only written to if
scene.clear = true
. So I changed the default forLScene
. This means anLScene
will not render over other plots that are rendered before.I tried a bunch of variations of
including 3d plots with ssao, 2d without, 2d without fxaa and different orders of operations (Menu-scene-plot, scene-menu-plot, scene-plot-menu). The Menu is always on top when opened, which is what I thought might break.
This also means that
backgroundcolor
now works forLScene
.