This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr swaps out the stencil test for a scissor test, which works regardless of
clear
. This does have some other potential issues though. The ssao postprocessor should only run once per pixel. With the scissor test multiple overlapping scenes could be running it, making things darker than they should be. To avoid this somewhat I only allowed leaf scenes (i.e. no children) to run SSAO. This means that SSAO will be wrong if a scene with children has a different projection matrix than it's children, or if its children cover less area. (I think this should be very rare?)See also: JuliaPlots/AbstractPlotting.jl#624
I'm pretty sure JuliaPlots/AbstractPlotting.jl#649 breaks SSAO again (it uses
clear = false
) which this pr should fix.