This repository has been archived by the owner on Jul 13, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr ...
pick(scene, rect)
, which was already in GLMakie, but not connected and I believe not working.pick_closest(scene, screen, xy, range)
as fallback/implementation forpick(scene, xy, range)
.pick_sorted(scene, screen, xy, range)
to get all plots and indices in a given range of xy, sorted by distance. Required for Data inspector #677.Requires JuliaPlots/GLMakie.jl#177.
I checked the following with a small scatter plot
pick(scene, pos)
pick(scene, pos, range)
with and without overloads from GLMakiepick(scene, rect)
pick_sorted(scene, pos, range)
with and without overloads from GLMakieThis removes what
pick(screen, rect)
forunique(pick(scene, rect))
so it's technically a breaking change. But I think that function was broken anyway and didn't follow the usual syntax.