-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
|
Would be cool if this also worked with |
Also related: MakieOrg/Makie.jl#810 |
I added an I'm also still thinking about how to best ignore plots. With how it is right now only plots that exist when My favorite solution for this is still adding an attribute (If you want to try this you'll need to checkout JuliaPlots/GLMakie.jl#177 and #696) |
If think this should be in a merga-able state now, if tests pass. Some things we should do later:
|
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:33
[2] rgbatuple(c::Char)
@ CairoMakie ~/.julia/packages/CairoMakie/GFZiw/src/utils.jl:87
[3] draw_poly(scene::Scene, screen::CairoMakie.CairoScreen{Cairo.CairoSurfaceIOStream{UInt32}}, poly::Poly{Tuple{Vector{Vector{Point{2, Float32}}}}}, points::Vector{Point{2, Float32}}, color::Char, model::StaticArrays.SMatrix{4, 4, Float32, 16}, strokecolor::Symbol, strokewidth::Float64)
@ CairoMakie ~/.julia/packages/CairoMakie/GFZiw/src/overrides.jl:45
[4] (::CairoMakie.var"#58#59"{Scene, CairoMakie.CairoScreen{Cairo.CairoSurfaceIOStream{UInt32}}, Poly{Tuple{Vector{Vector{Point{2, Float32}}}}}})(points::Vector{Point{2, Float32}}, color::Char, strokecolor::Symbol, strokewidth::Float64)
@ CairoMakie ~/.julia/packages/CairoMakie/GFZiw/src/overrides.jl:56
[5] broadcast_foreach(::Function, ::Vector{Vector{Point{2, Float32}}}, ::Vararg{Any, N} where N)
@ AbstractPlotting ~/work/AbstractPlotting.jl/AbstractPlotting.jl/src/utilities/utilities.jl:162
[6] draw_poly(scene::Scene, screen::CairoMakie.CairoScreen{Cairo.CairoSurfaceIOStream{UInt32}}, poly::Poly{Tuple{Vector{Vector{Point{2, Float32}}}}}, points_list::Vector{Vector{Point{2, Float32}}})
@ CairoMakie ~/.julia/packages/CairoMakie/GFZiw/src/overrides.jl:53 Could this be related to JuliaPlots/CairoMakie.jl#159 @jkrumbiegel ? |
I checked a couple of plots, everything seems to be working. I also split up the docs for interactivity a bit, because I thought it was getting a bit large and fragmented for one page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great :)
Plots TODO:
volume?textAny plot that isn't listed will fallback to the primitives it uses. (I.e. mesh, meshscatter, scatter, lines, linesegments, surface, heatmap, image, volume, text)
General/outside TODO:
includeAlternatively adjust SSAO/the renderloop such that SSAO works withmodel
in the calculation of bounding boxes so that the 3D indicator works with a background mesh.clear = false
so that we can use the figure scene.Add pickable attribute GLMakie.jl#174 orChange ranged pick to return all plots sorted by distance GLMakie.jl#177 and Update pick functions #696 So that certain plots can be excluded when picking at range.pick(..., range)
Axis3
To try it out, get JuliaPlots/GLMakie.jl#177 and #696 and use