Consider using @typescript-eslint/class-methods-use-this
#6
Assignees
Labels
Comments
Kenneth-Sills
added a commit
that referenced
this issue
Aug 25, 2024
By default, this does not deviate in behavior from the original rule. It does, however, provide users with additional configuration options to disable errors when this is not used in classes that implement interfaces or methods that explicitly override parent methods. The configuration we provide has been left at the default, though, since those rules are arguably over-permissive in the pursuit of not requiring type information. Closes #6
|
🎉 This issue has been resolved in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Migrated from upstream issue.
There is a new @typescript-eslint/class-methods-use-this rule which makes it possible to disable the rule in the case of overrides and interface.
For example, using this (with the updated options) prevents the pesky situation where an abstract class defines some abstract methods which do NOT necessarily use this, but which need to be class methods due to the abstract class definition.
Note by maintainer:
typescript-eslintis doing their best to avoid type information being required where it's not required, but in this case saying that any class implementing an interface no longer needs any method to use this is just a wide net. I'm more amenable to ignoring methods withoverride.The text was updated successfully, but these errors were encountered: